Problem/Motivation

In preparation to expose Drupal Components outside of Drupal we added a composer.json file to every component and a "replace" section to core/composer.json.

Right now drupal/core-assertion is missing from the drupal/core replace section.

Proposed resolution

- Fix the drupal/core replace section to have the drupal/core-assertion component declared.
- Add any external drupal/core-assertion requirements to drupal/core/composer.json and have composer update the other drupal/core/composer.* files.
- Add to Drupal\Tests\ComposerIntegrationTest::getPaths().

CommentFileSizeAuthor
#4 2752127.patch510 bytesjalpesh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Eric_A created an issue. See original summary.

Eric_A’s picture

Eric_A CreditAttribution: Eric_A commented
Issue summary: View changes
jalpesh’s picture

jalpesh CreditAttribution: jalpesh as a volunteer and at Cybage Software Pvt Ltd. commented
Assigned: Unassigned » jalpesh
jalpesh’s picture

jalpesh CreditAttribution: jalpesh as a volunteer and at Cybage Software Pvt Ltd. commented
Status: Active » Needs review
FileSize
2752127.patch510 bytes

Here we go with patch. Thanks

Eric_A’s picture

Eric_A CreditAttribution: Eric_A commented
Status: Needs review » Reviewed & tested by the community
Related issues: +#2600716: Add composer.json to \Drupal\Component\Assertion component., +#2337283: Add a composer.json file to every component

Thanks!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 2752127.patch, failed testing.

Eric_A’s picture

Eric_A CreditAttribution: Eric_A commented
Status: Needs work » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed cc54a9d and pushed to 8.1.x. Thanks!

  • alexpott committed 9e73da7 on 8.2.x 
    Issue #2752127 by jalpesh, Eric_A: drupal/core-assertion is missing from...

  • alexpott committed cc54a9d on 8.1.x 
    Issue #2752127 by jalpesh, Eric_A: drupal/core-assertion is missing from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.