Closed (fixed)
Project:
Drupal core
Version:
8.2.x-dev
Component:
theme system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
20 Jun 2016 at 01:28 UTC
Updated:
30 Jul 2016 at 22:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
Jeff Burnz commentedComment #3
mohit_aghera commentedComment #4
joelpittetThat's neat, the snippet doesn't need the hook? I'd check but I'm on a phone atm. Thanks for the fix.
Comment #5
prateekjain commentedPatch looks good. Changing it to RTBC
Comment #6
Jeff Burnz commentedlooks good, but I note the test doesn't have the type declaration, should we update that also, is it required etc?
Comment #7
lhuria94 commentedYes the snippet doesn't need the hook, updating the patch with required parameter and documentation changes.
Comment #8
joelpittetThank you. That is a nice clear cleanup
Comment #10
joelpittetComment #13
xjmThe patch in #7 does look best to me.
Regarding #6, types are indeed required now, but see the core scope documentation for coding standards for why added data types should not be included in this patch.
Committed 8e04ab6 and pushed to 8.2.x and 8.1.x. Thanks!