Rewrite EntityUrlTest

It is amazing how much more readable your new tests are. On top of that it adds test coverage and provides the points you outlined in the issue summary.

Here are just a few small remarks

1. +++ b/core/tests/Drupal/Tests/Core/Entity/EntityUrlTest.php
   @@ -2,377 +2,482 @@
   +   * @expectedException \Drupal\Core\Entity\EntityMalformedException
   +   * @expectedExceptionMessage The "test_entity" entity cannot have a URI as it does not have an ID
       */
   

   Note: Since https://thephp.cc/news/2016/02/questioning-phpunit-best-practices the annotation seems not longer be the right way to use here

2. +++ b/core/tests/Drupal/Tests/Core/Entity/EntityUrlTest.php
   @@ -2,377 +2,482 @@
   +  public function testToUrlLinkTemplateRevision($is_default_revision, $link_template, $expected_route_name, array $expected_route_parameters) {
   ...
   +    $test_cases['default_revision'] = [TRUE, 'canonical', 'entity.test_entity.canonical', $route_parameters];
   ...
   +    $test_cases['non_default_revision'] = [FALSE, 'revision', 'entity.test_entity.revision', $route_parameters];
   

   One tricky I learned recently from someone: Not use TRUE/FALSE in providers but rather simply introduce named constants like static::DEFAULT_REVISION and static::NON_DEFAULT_REVISION to improve readability. What do you think about it?

3. +++ b/core/tests/Drupal/Tests/Core/Entity/EntityUrlTest.php
   @@ -2,377 +2,482 @@
   +    $this->assertUrl('entity.test_entity.collection', [], $entity, $url);
   +    // The 'collection' link template because it does not get the 'language'
   +    // URL option.
   +    $this->assertNull($url->getOption('language'));
   

   Is there a reason you didn't included the language into the assertUrl method? It seems to just make sense to add it as an additional optional parameter at the end. Many of the great test methods you wrote use it now.

Sorry that was pure laziness/arrogance on my part of not running the test locally. :-/

Don't you feel bad about the global climate change caused by that ?

Committed c244dc4 and pushed to 8.1.x and 8.2.x. Thanks!