According to https://www.drupal.org/node/1231390 the geoloaction field (drupal 8 version) is not validated even it is marked as required:

When switching on the 'required field' checkbox in a Geolocation field's settings, the field is not required anyhow.
The lat/lon can be empty, without being 'noticed' by the default drupal checks.

If I don't set any value, I can submit the form, although it is required. This leads to the error "This value should be null.", which is not field specific and unhelpful for the user ("I don't know, what's wrong with my inputs?!").

CommentFileSizeAuthor
#16 2748363-13-improve-error-message-on-empty-widget-plus-tests.patch6.26 KBchristianadamski
#14 2748363-13-improve-error-message-on-empty-geocoder-widget.patch2.99 KBchristianadamski
#13 2748363-13-improve-error-message-on-empty-geocoder-widget.patch1.55 KBchristianadamski
#7 thisvalueshouldnotbenull.JPG77.33 KBpminf

Comments

pminf created an issue. See original summary.

pminf’s picture

pminf
Primary language German
Location Nuremburg (Germany), formerly Dresden
commented
Issue summary: View changes

fixed typo

christianadamski’s picture

christianadamski commented

Hey pminf,

1.) As mentioned in your linked issue, submitting empty lat / lng values despite field being required was already fixed.
2.) The required empty field is highlighted as erroneous, so it's not like the user has no idea what's happening.

I agree the message is not as helpful as it could be.

christianadamski’s picture

christianadamski commented

Do you use the default widget to input your data?

christianadamski’s picture

christianadamski commented
Status: Active » Fixed

Added "#required" parameters to the lat/lng widget. It will now correctly state the field names that are missing, as well as indicate that little red *.

pminf’s picture

pminf
Primary language German
Location Nuremburg (Germany), formerly Dresden
commented
Status: Fixed » Needs work
StatusFileSize
new thisvalueshouldnotbenull.JPG77.33 KB

Sorry for the missing information. I opened this issue because it seemed to be fixed in version 7.x but not in 8.x. It might be related to the Geolocation Google Geocoder widget.

W've checked your last fix but it didn't work.

Steps to reproduce on simplytest.me:

  1. Create project of geolocation 8.x-1.5 with English standard profile.
  2. Install module geolocation.
  3. Add field geolocation to node type basic page.
  4. Set it as required field and choose form display widget Geolocation Google Geocoder.
  5. Create new Basic Page without setting the coordinates

You get the error message "This value should not be null." and the geolocation field is not marked as invalid (see screenshot).

christianadamski’s picture

christianadamski commented
Status: Needs work » Fixed

Please test again with the latest 8.x-1.x-DEV release. The 8.x-1.5 branch does not contain any of these changes.

pminf’s picture

pminf
Primary language German
Location Nuremburg (Germany), formerly Dresden
commented
Status: Fixed » Needs work

I've tested the 8.x-1.x branch on simplytest.me which equates to the 8.x-1.x-DEV release. Same problem here.

christianadamski’s picture

christianadamski commented

Ooooh, we're talking about the geocoder widget now. Yeah ok, I was talking about the default one. Yeah ok.

christianadamski’s picture

christianadamski commented
christianadamski’s picture

christianadamski commented
Title: Making a Geolocation field 'required field' » Making a Geolocation field 'required field' in all widgets
christianadamski’s picture

christianadamski commented
Status: Needs work » Needs review
StatusFileSize
new 2748363-13-improve-error-message-on-empty-geocoder-widget.patch1.55 KB
christianadamski’s picture

christianadamski commented
StatusFileSize
new 2748363-13-improve-error-message-on-empty-geocoder-widget.patch2.99 KB
christianadamski’s picture

christianadamski commented

Added more appropriate messages for geocoder widget and HTML5 widget.

christianadamski’s picture

christianadamski commented
StatusFileSize
new 2748363-13-improve-error-message-on-empty-widget-plus-tests.patch6.26 KB

Added tests as well.

  • ChristianAdamski committed 871b2a3 on 8.x-1.x 
    Issue #2748363 by ChristianAdamski, pminf: Making a Geolocation field '...
christianadamski’s picture

christianadamski commented
Status: Needs review » Fixed

Status: Fixed » Needs work

The last submitted patch, 16: 2748363-13-improve-error-message-on-empty-widget-plus-tests.patch, failed testing.

The last submitted patch, 16: 2748363-13-improve-error-message-on-empty-widget-plus-tests.patch, failed testing.

The last submitted patch, 16: 2748363-13-improve-error-message-on-empty-widget-plus-tests.patch, failed testing.

The last submitted patch, 16: 2748363-13-improve-error-message-on-empty-widget-plus-tests.patch, failed testing.

christianadamski’s picture

christianadamski commented
Status: Needs work » Fixed

Failure is ok. I already committed this, so Patches do not apply anymore.

pminf’s picture

pminf
Primary language German
Location Nuremburg (Germany), formerly Dresden
commented

Thank you! Serverside validation now seems to work as expected. But what about clientside validation? If I don't set a value, I should not be able to submit the form (like required plain text or file upload fields).

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.