Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.While investigating https://www.drupal.org/node/2744495, I found changes made to settings.php to override Open ID Google client ID and secret ID were being displayed in the admin configuration form /admin/config/services/openid-connect due to the code in src/Form/SettingsForm.php:
$configuration = $this->config('openid_connect.settings.' . $client_name)
rather than the use of:
$configuration = $this->configFactory()
->getEditable('openid_connect.settings.' . $client_name)
->get('settings');
This the the potential side affect of storing overridden values from code into the database when saving the form (see https://www.drupal.org/node/1928898)
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | openid_connect_admin_config_override-2746587-3.patch | 2.14 KB | sanduhrs |
| #2 | openid_connect_admin_config_override-2746587-2.patch | 2.08 KB | kducharm |
Comments
Comment #2
kducharm commentedPatch created to use getEditable() instead of get(), also rename $config to $config_settings to avoid confusion with $configuration
Comment #3
sanduhrsSlightly modified, thanks for the patch!
Comment #4
sanduhrsComment #6
sanduhrs