#2745225: Provide debugging information for AMP metadata added the ability to provide configuration for the necessary metadata to create the JSON needed for Top Stories rich snippets. The JSON output by the AMP theme is now redundant and should be removed so that there aren't two blocks of JSON data.

We should also remove the variable preparation going on in amp.theme currently used in html.html.twig for JSON. This code has been fiddly to work with, particularly the code related to the logo, so this should help reduce potential errors in the theme.

CommentFileSizeAuthor
#8 2745227-8-remove-theme-json.patch2.74 KBrainbowarray
#3 2745227-3-remove-theme-json.patch4.72 KBrainbowarray

Comments

mdrummond created an issue. See original summary.

rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
Assigned: Unassigned » rainbowarray
rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
StatusFileSize
new 2745227-3-remove-theme-json.patch4.72 KB

This removes the JSON added in head by the theme as that JSON can now be added by configuring AMP metadata as per #2717641: Add support for 'Top Stories with AMP'.

rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
Status: Active » Needs review

  • mdrummond committed 45a6961 on 8.x-1.x 
    Issue #2745227 by mdrummond: Remove JSON output by AMP theme
rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
Status: Needs review » Fixed
rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
Version: 8.x-1.x-dev » 7.x-1.x-dev
Status: Fixed » Needs work

With #2734533: AMP metadata for Top Stories support. going in, we need to do this for D7 as well.

rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new 2745227-8-remove-theme-json.patch2.74 KB

Here's the D7 patch.

  • mdrummond committed 2a8746b on 7.x-1.x 
    Issue #2745227 by mdrummond: Remove JSON output by AMP theme
rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.