Problem/Motivation

Quote from \Drupal\block\Entity\Block::conditionPluginManager

  protected function conditionPluginManager() {
    $this->conditionPluginManager;

This line doesn't do anything

Proposed resolution

Let's get rid of it.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 irrelevent-code-removal-2744647-3.patch564 byteschishah92

Comments

dawehner created an issue. See original summary.

chishah92’s picture

chishah92 commented
Assigned: Unassigned » chishah92
chishah92’s picture

chishah92 commented
Status: Active » Needs review
StatusFileSize
new irrelevent-code-removal-2744647-3.patch564 bytes

Added a patch which removes that line of code.

Thanks!
~Chirag

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quickfix

Thank you

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed c0945c1 and pushed to 8.1.x and 8.2.x. Thanks!

Removed from 8.1.x as well because it's completely safe to do this.

  • alexpott committed 9eb8c7a on 8.2.x 
    Issue #2744647 by chishah92: \Drupal\block\Entity\Block::...

  • alexpott committed c0945c1 on 8.1.x 
    Issue #2744647 by chishah92: \Drupal\block\Entity\Block::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.