Hi,

After refund an order, the order is not seen in the order list and also throwing an error 'undefined'.

CommentFileSizeAuthor
#9 after_refund_an_order-2736639-9.patch4.61 KBanish.a
#3 refund_issue_fixed-2736639-11243455.patch5.93 KBsreejith.ms

Comments

harivenu_zyxware created an issue. See original summary.

sreejith.ms’s picture

sreejith.ms commented
Assigned: Unassigned » sreejith.ms
sreejith.ms’s picture

sreejith.ms commented
StatusFileSize
new refund_issue_fixed-2736639-11243455.patch5.93 KB

Hi,
I fixed the issue with the refund action in affirm. Please find the patch herewith.

sreejith.ms’s picture

sreejith.ms commented
Status: Active » Needs review

Hi,
Please review the patch that I have submitted.

Status: Needs review » Needs work

The last submitted patch, 3: refund_issue_fixed-2736639-11243455.patch, failed testing.

The last submitted patch, 3: refund_issue_fixed-2736639-11243455.patch, failed testing.

sreejith.ms’s picture

sreejith.ms commented
Assigned: sreejith.ms » Unassigned
Status: Needs work » Needs review
anish_zyxware’s picture

anish_zyxware commented
Status: Needs review » Needs work

The code break tests. It may not be related. But code cannot be merged till tests are working. Else, we may never know which code broke which.

Also, tests need to be added for new fixes, if possible, especially critical ones.

anish.a’s picture

anish.a commented
StatusFileSize
new after_refund_an_order-2736639-9.patch4.61 KB

Patch for removing tests.

  • anish.a committed 88fe3b3 on 7.x-1.x 
    Issue #2736639 by sreejith.ms, anish.a: After refund an order, the order...
anish_zyxware’s picture

anish_zyxware commented
Status: Needs work » Fixed

Merging as the testing has been paused as of moment.
https://www.drupal.org/node/2730043

  • anish.a committed 88fe3b3 on 8.x-1.x 
    Issue #2736639 by sreejith.ms, anish.a: After refund an order, the order...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.