RE: #2626950: Depend on Crop API for storage

I was working on an issue in the Focal Point issue queue and PHPUnit tests kept failing because I was adding a new dependency (on the crop module) in focal_point.info.yml. Tim Plunkett pointed out that I should add a test_dependies entry instead and starting at this comment the tests started passing as expected (tim++).

When the final patch was ready and, all tests passed, I committed it. This included a change to focal_point.info.yml where I removed the crop module test_dependecy and added a dependency. At this point, my branch tests started to fail. Shouldn't testbot have recognized my new dependency?

For the time being I have recommitted the test_dependencies in my focal_point.info.yml but I don't believe this should be needed

Comments

bleen created an issue. See original summary.

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Component: Code » Codebase Build
Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Status: Active » Fixed

Okay, drupalci is now using composer to construct the codebase to be tested.

What this means is that is you would like drupalci to understand that you have changes to your dependency requirements, you need to have a composer.json in your module's directory that has your modules dependency requirements expressed. Then, new patches that modify your composer.json will be understood by the testbot, and will affect the build, and will not require a commit to tell the testbot about your new dependency before you are sure you need it.

Please open a support issue if theres any way we can be of further assistance.

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.