I see some warnings when code runs through code sniffer.Attaching the screenshot.
Code cleanup warnings

CommentFileSizeAuthor
#2 Screenshot from 2016-05-18 13:14:14.png33.73 KBarpitr
#2 code-cleanup-2728221-2.patch866 bytesarpitr
Screenshot from 2016-05-18 13:13:02.png118.67 KBarpitr

Comments

arpitr created an issue. See original summary.

arpitr’s picture

arpitr commented
Assigned: arpitr » Unassigned
StatusFileSize
new code-cleanup-2728221-2.patch866 bytes
new Screenshot from 2016-05-18 13:14:14.png33.73 KB

Patch for code cleanup.

After fixing sniffer returns result as
After Cleanup

arpitr’s picture

arpitr commented
Issue summary: View changes
arpitr’s picture

arpitr commented
Issue summary: View changes
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Reviewed & tested by the community

Patch looks pretty straight forward

freakalis’s picture

freakalis commented
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Closed (outdated)
Issue tags: -code cleanup

I am closing this issue, which was created for a project version compatible with a Drupal release no longer supported. Feel free to re-open the issue, if it is still relevant for a project version compatible with a supported Drupal release.