Hi, the script js tag that adds the components isn't properly closed.

The script ends:

<script ... />

And must be:

<script ...></script>

Add patch.

CommentFileSizeAuthor
#7 2726779-closing-script-element.patch691 bytesrainbowarray
amp.module.diff991 bytesanacona16

Comments

anacona16 created an issue. See original summary.

anacona16’s picture

anacona16 commented
Issue summary: View changes
anacona16’s picture

anacona16 commented
Title: Wrong close script tag » Wrong closed script tag
jeevanbhushetty’s picture

jeevanbhushetty commented
Status: Active » Needs review

Hi @anacona16, please move ticket in "Needs review" state once the work is done, So that community can review and commit the path.

jeevanbhushetty’s picture

jeevanbhushetty commented
Status: Needs review » Reviewed & tested by the community

This looks good.

jeevanbhushetty’s picture

jeevanbhushetty commented
Status: Reviewed & tested by the community » Needs work

Sorry updated wrong issue.

rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
Title: Wrong closed script tag » Provide closing script tag
StatusFileSize
new 2726779-closing-script-element.patch691 bytes

Good catch on finding this bug. This solution allows us to avoid writing markup within a theme function, which keeps this somewhat more flexible.

rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
Project: Accelerated Mobile Pages (AMP) » AMP Theme

The fix will take place in the theme, so moving this issue to that queue.

  • mdrummond committed beb8ee1 on 7.x-1.x 
    Issue #2726779 by anacona16, mdrummond: Provide closing script tag.
rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.