The regular expression that look at output from nginx -V to among other things determine if this version supports limit_conn_zone only looks at the first character in the second part of the version and now when version 1.10 is available it fails to recognise it as a modern version. Adding [0-9]+ would be enough to support all coming versions of nginx.

$this->server->nginx_is_modern = preg_match("/nginx\/1\.((1\.(8|9|(1[0-9]+)))|((2|3|4|5|6|7|8|9|[0-9]+)\.))/", implode('', drush_shell_exec_output()), $match);
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

auth created an issue. See original summary.

omega8cc’s picture

@auth Yeah, it is a very old check we need to update. Do you want to submit a patch? Thanks for the heads-up!

auth’s picture

I can submit a patch

auth’s picture

Attaching patch to cover nginx versions 1.10-1.99

auth’s picture

Status: Active » Needs review
omega8cc’s picture

The [1-9][0-9]+ chain looks better than just [0-9]+ added there, thanks!

  • omega8cc committed 90dfe7b on 7.x-3.x authored by auth
    Issue #2725771 by auth: nginx 1.10 does not return nginx_is_modern ==...
omega8cc’s picture

Status: Needs review » Fixed

Committed, thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.