Drupal 10, the latest version of the open-source digital experience platform with even more features, is here.The regular expression that look at output from nginx -V to among other things determine if this version supports limit_conn_zone only looks at the first character in the second part of the version and now when version 1.10 is available it fails to recognise it as a modern version. Adding [0-9]+ would be enough to support all coming versions of nginx.
$this->server->nginx_is_modern = preg_match("/nginx\/1\.((1\.(8|9|(1[0-9]+)))|((2|3|4|5|6|7|8|9|[0-9]+)\.))/", implode('', drush_shell_exec_output()), $match);
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | make_nginx_is_modern_support_nginx_1_xx-2725771-4.patch | 3.55 KB | auth |











Comments
Comment #2
omega8cc CreditAttribution: omega8cc commented@auth Yeah, it is a very old check we need to update. Do you want to submit a patch? Thanks for the heads-up!
Comment #3
auth CreditAttribution: auth commentedI can submit a patch
Comment #4
auth CreditAttribution: auth commentedAttaching patch to cover nginx versions 1.10-1.99
Comment #5
auth CreditAttribution: auth commentedComment #6
omega8cc CreditAttribution: omega8cc commentedThe
[1-9][0-9]+chain looks better than just[0-9]+added there, thanks!Comment #8
omega8cc CreditAttribution: omega8cc commentedCommitted, thank you!