Generated images have mime type image/jpg instead of image/jpeg.

CommentFileSizeAuthor
#5 2725425-image-generate-mime-type.patch1.78 KBmfb
#3 2725425-test-only.patch934 bytesmfb
image-generate-mime-type.patch889 bytesmfb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mfb created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Makes sense, but I am afraid without a test this will not go in

mfb’s picture

mfb
they or he
CreditAttribution: mfb commented
Status: Needs work » Needs review
FileSize
2725425-test-only.patch934 bytes

Here's a test

Status: Needs review » Needs work

The last submitted patch, 3: 2725425-test-only.patch, failed testing.

mfb’s picture

mfb
they or he
CreditAttribution: mfb commented
Status: Needs work » Needs review
FileSize
2725425-image-generate-mime-type.patch1.78 KB
mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs tests

Looks good to me, has tests

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 7f674d9 and pushed to 8.1.x and 8.2.x. Thanks!

Committed to 8.1.x as well because ::generateSampleValue() is not used in run-time code and therefore vey low-risk.

  • alexpott committed f8f34be on 8.2.x 
    Issue #2725425 by mfb: Incorrect mime type on generated images

  • alexpott committed 7f674d9 on 8.1.x 
    Issue #2725425 by mfb: Incorrect mime type on generated images

(cherry...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.