Problem/Motivation

New Drupal8 workflow and archtecture encourages to use composer to manage external dependencies. Geofield module is currently depending on GeoPHP module, which is just a wrapper for the GeoPHP library.

The aim of this issue is get rid of the dependency on GeoPHP module and use composer.json file to download and autoload GeoPHP classes.

This make things easier, more sustainable and more likely the new D8 standards.

Proposed resolution

  • Add a composer.json file declaring dependency on GeoPHP library.
  • Remove dependency on GeoPHP module.
  • Create new geofild.geophp service replacing geophp.geophp service declared in GeoPHP module.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

New geofield.geophp service declared in this module

CommentFileSizeAuthor
#3 deprecate_geophp_module-2724943-3.patch6.64 KBplopesc
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

plopesc created an issue. See original summary.

plopesc’s picture

plopesc
he/him
Primary language Spanish
CreditAttribution: plopesc at Bluespark commented
Title: Deprecate GeoPHP module and manag dependencies using composer » Deprecate GeoPHP module and manage dependencies using composer
plopesc’s picture

plopesc
he/him
Primary language Spanish
CreditAttribution: plopesc at Bluespark commented
Status: Active » Needs review
FileSize
deprecate_geophp_module-2724943-3.patch6.64 KB

Here is the patch I created for this task.

  • plopesc committed 3c0146e on 8.x-1.x 
    Issue #2724943 by plopesc: Deprecate GeoPHP module and manage...
NetNerdy’s picture

NetNerdy CreditAttribution: NetNerdy commented

hi plopesc,
thank you very much for your works by this important module!

is the patch #3 already included by current -dev?
version that's mean:
+Last updated: May 13, 2016 - 20:33
Last packaged version: 8.x-1.0-alpha1+18-dev

thank you for clearing ;)

NetNerdy’s picture

NetNerdy CreditAttribution: NetNerdy commented

included...have seen it by code ;)

plopesc’s picture

plopesc
he/him
Primary language Spanish
CreditAttribution: plopesc at Bluespark commented
Status: Needs review » Fixed

Patch already pushed.

Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

davidsickmiller’s picture

davidsickmiller CreditAttribution: davidsickmiller commented

In case anyone has the same problem as me, installing this way seems to no longer work automatically (at least with Drush 8.1.12):

drush dl geofield
drush en geofield

Instead, perform the download using Composer, which takes care of the geophp dependencies, before enabling the module:

composer require drupal/geofield
drush en geofield