When running the module through phpcs with the Drupal standards the following errors were reported
phpcs -s --standard=Drupal sites/default/modules/entity_reference_views_select/
FILE: ...n/Field/FieldWidget/EntityReferenceViewsOptionsButtonsWidget.php
----------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
----------------------------------------------------------------------
29 | ERROR | Missing short description in doc comment
| | (Drupal.Commenting.DocComment.MissingShort)
34 | ERROR | Missing short description in doc comment
| | (Drupal.Commenting.DocComment.MissingShort)
37 | ERROR | Class property $view_factory should use lowerCamel naming
| | without underscores
| | (Drupal.NamingConventions.ValidVariableName.LowerCamelName)
39 | ERROR | Missing short description in doc comment
| | (Drupal.Commenting.DocComment.MissingShort)
42 | ERROR | Class property $view_loader should use lowerCamel naming
| | without underscores
| | (Drupal.NamingConventions.ValidVariableName.LowerCamelName)
----------------------------------------------------------------------
FILE: ...in/Field/FieldWidget/EntityReferenceViewsOptionsSelectWidget.php
----------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
----------------------------------------------------------------------
30 | ERROR | Missing short description in doc comment
| | (Drupal.Commenting.DocComment.MissingShort)
35 | ERROR | Missing short description in doc comment
| | (Drupal.Commenting.DocComment.MissingShort)
38 | ERROR | Class property $view_factory should use lowerCamel naming
| | without underscores
| | (Drupal.NamingConventions.ValidVariableName.LowerCamelName)
40 | ERROR | Missing short description in doc comment
| | (Drupal.Commenting.DocComment.MissingShort)
43 | ERROR | Class property $view_loader should use lowerCamel naming
| | without underscores
| | (Drupal.NamingConventions.ValidVariableName.LowerCamelName)
----------------------------------------------------------------------| Comment | File | Size | Author |
|---|---|---|---|
| #2 | entity_reference_views_select-coding-standard-fixes-2723679-2.patch | 4.78 KB | anoopjohn |
Comments
Comment #2
anoopjohn commentedPlease find attached a patch that fixes the issues reported.
Comment #4
el1_1el commentedAdditionally, there were a few new standards issues since this was opened according to phpcs. theyve all been fixed in the dev branch.
Sorry I waited so long, but was going to include with possible bug fixes that never materialized. I'll add this to any new releases. Thanks!
Comment #5
el1_1el commented