Trigger deprecated warning for ViewsData::get(NULL)

Duplicate of #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch

Let's add a deprecated warning.

Adds a deprecation @trigger_error.

Patch looks good to me, thanks!

+++ b/core/modules/views/src/ViewsData.php
@@ -137,12 +137,14 @@ public function getAll() {
+      @trigger_error('Calling get() without the $key argument is deprecated in drupal:8.8.0 and is required in drupal:9.0.0. See https://www.drupal.org/node/3090442', E_USER_DEPRECATED);

+++ b/core/modules/views/tests/src/Unit/ViewsDataTest.php
@@ -642,6 +642,9 @@ public function testCacheCallsWithoutWarmCacheAndGetMultipleTables() {
+   * @expectedDeprecation Calling get() without the $key argument is deprecated in drupal:8.8.0 and is required in drupal:9.0.0. See https://www.drupal.org/node/3090442

8.8 or 8.2?

Removed a couple of usages.

Still some fails, but this should fix some too.

Found another one.

This should be green.

Looks good to me! +1 to rtbc

Thanks, for the review. Indeed it is RTBC.

#14 looks good to me. +1 to RTBC

Committed 9ac5c2b and pushed to 9.0.x, cherry-picked to 8.9.x and 8.8.x. Thanks!

Who added @mattc321 to the credit list. Did he do something here?

I was unable to find any proof of contribution form @mattc321 so removing @mattc321 for now. Feel free to add @mattc321 back if you have more info.

-Thanks
Jibran

@jibran mattc321 opened the issue in the first place, we usually credit for that.

Sorry, I missed that.