Fix Drupal.Commenting.FunctionComment.InvalidReturn and Drupal.Commenting.FunctionComment.VoidReturn

Re-running test.

+++ b/core/modules/field/tests/src/Kernel/FieldKernelTestBase.php
@@ -137,10 +137,10 @@ protected function entitySaveReload(EntityInterface $entity) {
+   * Note: Function does not return anything.
+   *
    * @param \Drupal\Core\Entity\EntityInterface $entity
    *   The entity to save.
-   *
-   * @return void

+++ b/core/modules/user/src/UserDataInterface.php
@@ -34,6 +34,8 @@ public function get($module, $uid = NULL, $name = NULL);
+   * Note: Function does not return anything.
+   *

@@ -42,14 +44,14 @@ public function get($module, $uid = NULL, $name = NULL);
+   * Note: Function does not return anything.
+   *

I don't think we need to add these notes. Also, strictly speaking, all methods return NULL, which isn't the same as 'nothing.' :-)

Needs a reroll after changes from #2721909: Fix Drupal.Commenting.FunctionComment.ReturnCommentIndentation

Not sure what you mean about the two patches...

Current patch gives me this:

FILE: ...l/pj2/drupal/core/lib/Drupal/Component/Datetime/DateTimePlus.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 458 | ERROR | Expected "bool" but found "boolean" for function return
     |       | type (Drupal.Commenting.FunctionComment.InvalidReturn)
----------------------------------------------------------------------

Also:

+++ b/core/lib/Drupal/Core/StreamWrapper/PhpStreamWrapperInterface.php
@@ -64,7 +64,7 @@ public function rmdir($path, $options);
   /**
-   * @return void
+   * Closes stream and does not return anything.
    */
   public function stream_close();

We don't need to say that it doesn't return anything.

Looks good, verified manually that a run of phpcs does not throw any errors with the changed phpcs.xml.dist file.

Committed 5f925ef and pushed to 8.1.x and 8.2.x. Thanks!

FILE: ...sk/dev/drupal/core/modules/field/src/Tests/FieldUnitTestBase.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 146 | ERROR | If there is no return value for a function, there must not
     |       | be a @return tag.
     |       | (Drupal.Commenting.FunctionComment.VoidReturn)
----------------------------------------------------------------------

Fixed on 8.1.x during commit.