After enabling this module, we will have to read the README to identify the details. It will be better if we could implement a hook_help or similar so that the developer can read it from the drupal side.

CommentFileSizeAuthor
#20 implement_hook_help-2721583-20.patch376 bytesglen.pinheiro
#12 disable_messages-implement_hook_help-2721583-12.patch5.19 KBnitinsp
#8 disable_messages-implement_hook_help-2721583-8.patch2.1 KBnitinsp
#5 disable_messages-implement_hook_help-2721583-5.patch2.1 KBnitinsp
#2 edit_issue_implement-2721583-1.patch5.24 KBvinod_kc

Comments

vinod_kc created an issue. See original summary.

vinod_kc’s picture

vinod_kc commented
StatusFileSize
new edit_issue_implement-2721583-1.patch5.24 KB
vinod_kc’s picture

vinod_kc commented
Assigned: vinod_kc » Unassigned
nitinsp’s picture

nitinsp commented
Assigned: Unassigned » nitinsp
nitinsp’s picture

nitinsp commented
Assigned: nitinsp » Unassigned
Status: Active » Needs review
StatusFileSize
new disable_messages-implement_hook_help-2721583-5.patch2.1 KB

I have implemented hook_help() and create patch file, please review this patch.

anish_zyxware’s picture

anish_zyxware commented

Nithin, Vinod already provided the patch. Can you please check whether your patchprovides any significant additions? If yes, please provide a new patch that includes vinod's patch, along an interdiff.

anish_zyxware’s picture

anish_zyxware commented
Status: Needs review » Needs work
nitinsp’s picture

nitinsp commented
StatusFileSize
new disable_messages-implement_hook_help-2721583-8.patch2.1 KB

Hi anish_zyxware,

I have removed unwanted description like we do not need to include all configuration details in hook_help, So I have removed this. As per coding standard replace <li>, <ol> tag with <dl>, <dt>. Also naming convention of first patch is not as per druapl patch standard. Now I have uploaded updated patch

nitinsp’s picture

nitinsp commented
Status: Needs work » Needs review
anish_zyxware’s picture

anish_zyxware commented
Status: Needs review » Needs work

Hello,

I meant that Vinod's patch is much more descriptive. But need changes as per coding standards. Can you work on top of that?
Apply the patch and change <li>, <ol> to <dl> , <dt> .

nitinsp’s picture

nitinsp commented
Assigned: Unassigned » nitinsp

Sure, I will work on that

nitinsp’s picture

nitinsp commented
StatusFileSize
new disable_messages-implement_hook_help-2721583-12.patch5.19 KB

Hi anish_zyxware,

As per drupal patch coding standard i have updated all the tags as well as correct some spell check mistake. Please apply and review updated patch.

nitinsp’s picture

nitinsp commented
Status: Needs work » Needs review
anish_zyxware’s picture

anish_zyxware commented
Status: Needs review » Fixed

Merged. Thanks for the patch.

  • anish.a committed b30f404 on 8.x-1.x authored by NitinSP 
    Issue #2721583 by NitinSP, vinod_kc: Implement hook_help
nitinsp’s picture

nitinsp commented
Assigned: nitinsp » Unassigned
Anonymous’s picture

Anonymous (not verified) commented

I think use Drupal\Core\Routing\RouteMatchInterface; is missing, because I get an error after installing the module.

anish_zyxware’s picture

anish_zyxware commented
Assigned: Unassigned » anish_zyxware
Status: Fixed » Needs work

I also noticed that. I will work on that.

glen.pinheiro’s picture

glen.pinheiro commented
Assigned: anish_zyxware » glen.pinheiro
glen.pinheiro’s picture

glen.pinheiro commented
Assigned: glen.pinheiro » Unassigned
Status: Needs work » Needs review
StatusFileSize
new implement_hook_help-2721583-20.patch376 bytes

Added use Drupal\Core\Routing\RouteMatchInterface; to the module.

anish_zyxware’s picture

anish_zyxware commented

I think that patch will work. Can you please check, @Almare ?

Anonymous’s picture

Anonymous (not verified) commented

The patch in #20 worked. I am just wondering where my patch is gone ... anyway. Problem solved

  • anish.a committed 2848753 on 8.x-1.x 
    Issue #2745777 #2721583 by anish.a: Crashes after install
anish_zyxware’s picture

anish_zyxware commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.