Closed (fixed)
Project:
Rules
Version:
8.x-3.x-dev
Component:
Rules Core
Priority:
Major
Category:
Bug report
Assigned:
Issue tags:
Reporter:
Created:
8 May 2016 at 15:44 UTC
Updated:
9 Mar 2019 at 07:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
tr commentedSo, if I understand correctly, right now in our tests we do things like:
The
->toArray()is needed because the signature forcreateAction()isExpressionManager::createAction($id, array $configuration)What you're proposing is to change the signature to
ExpressionManager::createAction($id, ContextConfig $config)(with similar changes forcreateRule(),createActionSet(), andcreateCondition()).This simply requires us to change the function signatures and move the
->toArray()call into the aboveExpressionManagermethods rather than calling->toArray()and passing the result to theExpressionManagermethods.Right?
That seems to be an almost trivial task if I correctly understand what you're proposing.
Comment #3
tr commentedComment #5
tr commentedComment #7
tr commentedCommitted. Feel free to re-open if I missed something.