Current classes like "RulesAction" are confusing and do not match the expected naming pattern. I'd be looking for "ActionExpression" - which should be the name imo. Alternative would be RulesActionExpression but I think we can save the Rules prefix in this case.

CommentFileSizeAuthor
#6 2721209-6-rename-expression-plugin-classes.patch22.99 KBtr
#4 2721209-4-rename-expression-plugin-classes.patch21.81 KBtr
#3 2721209-3-rename-expression-plugin-classes.patch12.46 KBtr

Comments

fago created an issue. See original summary.

tr’s picture

tr commented
Issue tags: +Novice, +Contributor

@fago marked this as a beta blocker, so let's get it done.

First, post a list of classes/interfaces to be renamed (everything under src/Plugin/RulesExpression ?) and their new names. Once we agree on that we need a big patch to do all the renaming. This seems to be a simple enough task that I've tagged it as "Novice" for those looking to learn how to contribute patches or for those looking for easier tasks to participate in. Or for those who just want to help out!

tr’s picture

tr commented
Status: Active » Needs review
StatusFileSize
new 2721209-3-rename-expression-plugin-classes.patch12.46 KB

First pass at a patch.

tr’s picture

tr commented
StatusFileSize
new 2721209-4-rename-expression-plugin-classes.patch21.81 KB

I think this covers everything. Let's see if the tests pass - that will let me know if I missed something.

Status: Needs review » Needs work

The last submitted patch, 4: 2721209-4-rename-expression-plugin-classes.patch, failed testing. View results

tr’s picture

tr commented
Status: Needs work » Needs review
StatusFileSize
new 2721209-6-rename-expression-plugin-classes.patch22.99 KB

Again. Hopefully it was just that one thing ...

tr’s picture

tr commented
Assigned: Unassigned » tr
sgroundwater’s picture

sgroundwater commented

Renaming classes may seem novice, I'd say this patch was a bit more. TR, nice clean-up, thank you for your time!! I can report this patch applies clean and looks good from my standpoint.

  • TR committed 9ed3c50 on 8.x-3.x 
    Issue #2721209 by TR: Rename expression plugin classes to use an...
tr’s picture

tr commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.