Motivation: When not using hot-links, in presence of reverse proxys (like varnish) the redirection returned lacks of a Cache-Control header, causing redirection loops (in theory the browser itself could cache the response ending in the same loop).
This patch adds a Cache-Control header which avoids that scenario.
Also it avoids returning a redirection at all when the requested image is a derivative and we fetched the original successfully.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | stage_file_proxy-no-hotlink-cache-header-and-skip-unnecesary-redirections_2.patch | 1.39 KB | niteman |
Comments
Comment #2
niteman commentedComment #3
gregglesComment #4
asrobI've just successfully applied this patch in 8.x-1.x. AFAIK that cache-control header is valid.
Comment #5
gregglesOne nitpick: the new comment about proxies needs closing punctuation for code style.
Comment #6
niteman commentedThanks for your quick review!
Sorry about the code style mistake. I've uploaded a new patch with closing puntuation.
Comment #7
asrobWorks well, thanks greggles and NITEMAN!
Comment #8
markdorisonRTBC.
Comment #9
geek-merlinGreat stuff. Looks like it also should be backported.
Comment #10
geek-merlinPicked the cache-control-header, left the original-file condition which was obsoleted in #2840952-13: Hotlink does not redirect to imagestyle path
Comment #12
geek-merlinComment #13
geek-merlin@NITEMAN: Just for curiosity: can you elaborate why we need the cache-control-header for fetch-file, but not for hotlink?
Also reopening to backport for D7.
See stage_file_proxy_init(), stage_file_proxy_process_file_uri().
Comment #14
geek-merlinWhile the D8 implementation first writes to disc and then does a redirect, D7 fetches, writes and delivers the result.
No redirection here, so does not apply to D7.
Comment #15
geek-merlin