In #2700377: Call to undefined method on manage display we fixed a bug, but we didn't add any test coverage. Would be nice to have that covered.

Issue fork name-2717853

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

slashrsm created an issue. See original summary.

alan d.’s picture

alan d. commented
Title: Add test coverage for "Call to undefined method on manage display" » Add NameFormatter test coverage

any test run on anything useful with the display settings will pick up PHP errors like this, so the task would be on something useful :)

bluegeek9’s picture

bluegeek9 commented
Assigned: Unassigned » bluegeek9

bluegeek9 changed the visibility of the branch 8.x-1.x to hidden.

bluegeek9 opened merge request !30

bluegeek9’s picture

bluegeek9 commented
Assigned: bluegeek9 » Unassigned
Status: Active » Needs review

liam morland made their first commit to this issue’s fork.

heddn’s picture

heddn
Primary language English
Location Illinois
commented

There's a lot of mocking going on. Wouldn't a kernel or functional test be an easier solution here?

bluegeek9’s picture

bluegeek9 commented
Assigned: Unassigned » bluegeek9
Status: Needs review » Active
bluegeek9’s picture

bluegeek9 commented
Assigned: bluegeek9 » Unassigned
Status: Active » Needs review

I added Kernel and Functional tests.

I updated NameFormatter.php::getListSettings()

I think my change is correct, but it should be reviewed.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Needs work

Commented on the MR.

bluegeek9’s picture

bluegeek9 commented
Status: Needs work » Fixed
//www.flaticon.com/free-icons/thank-you Thank you for your contribution! Your continued support makes this project sustainable.
There are multiple ways to show appreciation for the work contributed to this project including:
  • Triage issues and adding more context to existing issues.
  • Flagging Name Field as a favorite on the project page to help others discover it and show your support.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.