Problem/Motivation

When a date-only field is rendered out with the default field formatter, an incorrect ISO timestamp attribute is attached to the <time> element. Basically, the time portion is taken from the current time, instead of using the default time (noon UTC).

Proposed resolution

Move the ISO date creation to after the default time has been set.

Remaining tasks

Fix problem.

Add test coverage.

User interface changes

None.

API changes

None.

Data model changes

None.

Comments

mpdonadio created an issue. See original summary.

mpdonadio’s picture

Issue summary: View changes
Status: Active » Needs review
Issue tags: +Needs tests
StatusFileSize
new2.59 KB

Still need to add the test to demonstrate the problem, but XPath isn't my strong point for a quick fix on this.

mpdonadio’s picture

Assigned: mpdonadio » Unassigned
Issue tags: -Needs tests
StatusFileSize
new1.98 KB
new3.07 KB
new2.29 KB

The last submitted patch, 2: 2716991-02.patch, failed testing.

The last submitted patch, 3: 2716991-test-only.patch, failed testing.

The last submitted patch, 3: 2716991-test-only.patch, failed testing.

mpdonadio’s picture

Version: 8.2.x-dev » 8.1.x-dev

I'm happy with this. Review away. Putting back to 8.1.x b/c this is a bug w/ a demonstrable test, and would qualify getting into a minor.

tstoeckler’s picture

Status: Needs review » Reviewed & tested by the community

Yup, thanks for the test coverage. Looks great!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 93447ea and pushed to 8.1.x and 8.2.x. Thanks!

  • alexpott committed 53e541d on 8.2.x
    Issue #2716991 by mpdonadio: Incorrect ISO datetime attribute for date-...

  • alexpott committed 93447ea on 8.1.x
    Issue #2716991 by mpdonadio: Incorrect ISO datetime attribute for date-...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.