Performed code review for uc_affirm module.

CommentFileSizeAuthor
#8 improve_documentation-2715983-8.patch4.64 KBsarikak
#5 improve_documentation-2715983-5.patch26.62 KBanish.a
#2 uc_affirm_code_review.patch15.75 KBsarikak

Comments

sarikak created an issue. See original summary.

sarikak’s picture

sarikak commented
StatusFileSize
new uc_affirm_code_review.patch15.75 KB

Performed code review and applied patches.

sarikak’s picture

sarikak commented
anish.a’s picture

anish.a commented
Status: Active » Needs work

There is a lot of coding standard issues still. Need to fix.

anish.a’s picture

anish.a commented
StatusFileSize
new improve_documentation-2715983-5.patch26.62 KB

Much better code.

  • anish.a committed 8c7244f on 7.x-1.x 
    Issue #2715983 by sarikak, anish.a: Improve documentation and code...
anish_zyxware’s picture

anish_zyxware commented
Status: Needs work » Fixed

Merged the patch. Thanks.

sarikak’s picture

sarikak commented
Status: Fixed » Needs review
StatusFileSize
new improve_documentation-2715983-8.patch4.64 KB

Applied patch for defining constants and modified documentation.

anish_zyxware’s picture

anish_zyxware commented
Status: Needs review » Fixed

Merged. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.