When we add a Color field and give it a label, the label gets overridden by the label "Color" for HTML5 Color Widget.

CommentFileSizeAuthor
#16 16_color_field_rc3_2711841.patch1.18 KBskippednote
#14 14_color_field_rc3_2711841.patch9.22 KBskippednote
#13 13_color_field_rc3_2711841.patch1.01 KBskippednote
#11 color_field_color_label_for_rc3_version_2711841_11_8_x_2_x.patch722 bytestrebormc
#9 add-fieldset-to-html5-color-field-2711841.patch1.16 KBAnonymous (not verified)
#2 color_field-color-label-2711841-2-8.x-2.x.patch1.04 KBVinayLondhe

Comments

VinayLondhe created an issue. See original summary.

VinayLondhe’s picture

VinayLondhe commented
Status: Active » Needs review
StatusFileSize
new color_field-color-label-2711841-2-8.x-2.x.patch1.04 KB

The below patch fixes the issue.

VinayLondhe’s picture

VinayLondhe commented
Title: Change title of the Color field from Color to Field Label » Change title of the Color field from Color to Field Label in HTML5 Color Picker

Status: Needs review » Needs work

The last submitted patch, 2: color_field-color-label-2711841-2-8.x-2.x.patch, failed testing.

geerlingguy’s picture

geerlingguy commented
Version: 8.x-2.0-rc1 » 8.x-2.x-dev
Status: Needs work » Needs review

Just ran into this as well; the field is always labeled 'Color' no matter what field label you choose.

dakku’s picture

dakku commented

++

RedLucas25’s picture

RedLucas25 commented

This is really just taking the code from the other widgets and using it for this widget, with one added check to set a default if there is no label. I am using this and it works. I think it's mergable.

RedLucas25’s picture

RedLucas25 commented
Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new add-fieldset-to-html5-color-field-2711841.patch1.16 KB

Add a fieldset with field label

kreatil’s picture

kreatil commented
Status: Needs review » Reviewed & tested by the community

I manually applied patch#2. I can confirm it works.

trebormc’s picture

trebormc
Primary language Catalan
commented
StatusFileSize
new color_field_color_label_for_rc3_version_2711841_11_8_x_2_x.patch722 bytes

modify the patch to works in rc3 version

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 11: color_field_color_label_for_rc3_version_2711841_11_8_x_2_x.patch, failed testing. View results

skippednote’s picture

skippednote commented
StatusFileSize
new 13_color_field_rc3_2711841.patch1.01 KB

Renders field label and description as setup during field creation. Also accommodates for the opacity field.

skippednote’s picture

skippednote commented
StatusFileSize
new 14_color_field_rc3_2711841.patch9.22 KB

Renders field label and description as setup during field creation. Also accommodates for the opacity field.
Missed adding the description when there is no opacity in the previous comment.

skippednote’s picture

skippednote commented
skippednote’s picture

skippednote commented
StatusFileSize
new 16_color_field_rc3_2711841.patch1.18 KB
nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 16: 16_color_field_rc3_2711841.patch, failed testing. View results

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Issue tags: +Needs tests

Now that #2985211: Create a test suit is in progress, tests are mandatory.
However, automatic tests are broken on the CI level for this project right now, so reports may be inaccurate especially if it says "Patch failed to apply" that is bunk quite likely.

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Needs work » Fixed
Issue tags: -Needs tests

Added test that fails without this patch. Committed patch and test. Thanks a lot!

  • NickWilde committed ccd7318 on 8.x-2.x 
    Issue #2711841 by skippednote, VinayLondhe, trebormc, NickWilde: Change...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.