We usually follow the rule that comment statement should be above the code which it belongs to. The php section of the phpunit.xml.dist does not comply with this.

<php>
  <!-- Set error reporting to E_ALL. -->
  <ini name="error_reporting" value="32767"/>
  <!-- Do not limit the amount of memory tests take to run. -->
  <ini name="memory_limit" value="-1"/>
  <env name="SIMPLETEST_BASE_URL" value=""/>
  <!-- Example SIMPLETEST_BASE_URL value: http://localhost -->
  <env name="SIMPLETEST_DB" value=""/>
  <!-- Example SIMPLETEST_DB value: mysql://username:password@localhost/databasename#table_prefix -->
  <env name="BROWSERTEST_OUTPUT_DIRECTORY" value=""/>
  <!-- Example BROWSERTEST_OUTPUT_DIRECTORY value: /path/to/webroot/sites/simpletest/browser_output -->
</php>
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Chi created an issue. See original summary.

pashupathi nath gajawada’s picture

Assigned: Unassigned » pashupathi nath gajawada

I'm looking into it.

pashupathi nath gajawada’s picture

Status: Active » Needs review
FileSize
951 bytes

Please find the attached patch which would fix this.

Chi’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed d14beab and pushed to 8.1.x. Thanks!

  • alexpott committed ea8e16e on 8.2.x
    Issue #2710103 by Pashupathi Nath Gajawada: Cleanup phpunit.xml.dist
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.