Drupal\config\Tests\ConfigFormOverrideTest fails for me locally because settings.php is not invalidated when it is written. This is because opcache.revalidate_freq prevents this. I think we should invalidate settings.php on every request or set opcache.revalidate_freq to 0 in tests.

CommentFileSizeAuthor
#5 2709541-5.patch729 bytesalexpott
#3 2709541-3.patch673 bytesalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented

I discovered this whilst working on #2699613: Set a shorter TTL for 404 responses in page_cache module which adds to test and changes settings.php

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Active » Needs review
FileSize
2709541-3.patch673 bytes
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented

What about adding opcache.validate_timestamps on top of it, just to be sure? People might use some high performance opcache settings locally, because they think they get some benefit out of it.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
FileSize
2709541-5.patch729 bytes

Yep that makes sense.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
Status: Needs review » Reviewed & tested by the community

I just love how 'on' is a boolean according to the documentation :)

  • catch committed de0c60b on 8.2.x 
    Issue #2709541 by alexpott, dawehner: Set opcache.revalidate_freq when...

  • catch committed b1f327f on 8.1.x 
    Issue #2709541 by alexpott, dawehner: Set opcache.revalidate_freq when...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.2.x and cherry-picked to 8.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.