Problem/Motivation

RevisionsOverviewDeriver creates local task for version history which usually appears along "View" and "Edit" tasks. Those usually use canonical as base route. RevisionsOverviewDeriver uses edit_form. This causes it's local task to disappear in many cases.

Proposed resolution

Use "entity.$entity_type_id.canonical" instead of "entity.$entity_type_id.edit_form".

CommentFileSizeAuthor
#6 test-only-2709489-6.patch1.74 KBCTaPByK
#6 2709489-6.patch2.42 KBCTaPByK
#3 2709489_1.patch697 bytesslashrsm

Comments

slashrsm created an issue. See original summary.

slashrsm’s picture

slashrsm commented
Status: Active » Needs review
Issue tags: +Needs tests

Patch. This needs to be tested IMO.

slashrsm’s picture

slashrsm commented
StatusFileSize
new 2709489_1.patch697 bytes

Meh...

dawehner’s picture

dawehner
Primary language German
commented

That one looks just perfect!

slashrsm’s picture

slashrsm commented
Status: Needs review » Needs work

We need to add tests.

CTaPByK’s picture

CTaPByK commented
Assigned: Unassigned » CTaPByK
Status: Needs work » Needs review
StatusFileSize
new 2709489-6.patch2.42 KB
new test-only-2709489-6.patch1.74 KB

I upgrade existing test RevisionRouteAccessTest, also i fix file entity_module_test.links.task.yml, i made mistake in this file yesterday...sorry for that. Test with patch is green in my localhost and test-only patch fails with error: Call to a member function click() on null.

sanja_m’s picture

sanja_m commented
Status: Needs review » Reviewed & tested by the community

I think it's OK, RTBC.

slashrsm’s picture

slashrsm commented

+1 Tried tests locally. Test only patch fails and full patch passes.

  • dawehner committed 881f388 on 8.x-1.x authored by CTaPByK 
    Issue #2709489 by CTaPByK, slashrsm: RevisionsOverviewDeriver uses wrong...
dawehner’s picture

dawehner
Primary language German
commented
Issue tags: -Needs tests

Thank you!

dawehner’s picture

dawehner
Primary language German
commented
Status: Reviewed & tested by the community » Fixed

.

  • dawehner committed 881f388 on 8.x-2.x authored by CTaPByK 
    Issue #2709489 by CTaPByK, slashrsm: RevisionsOverviewDeriver uses wrong...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

The last submitted patch, 3: 2709489_1.patch, failed testing.

The last submitted patch, 6: 2709489-6.patch, failed testing.

Status: Closed (fixed) » Needs work

The last submitted patch, 6: test-only-2709489-6.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Closed (fixed)

Too late testbot.