Version 2.x is completely broken. with syntax errors and coding issues. This task will be used to fix all major errors.

CommentFileSizeAuthor
#4 rules_forms-coding_standards_2707443-4.patch50.43 KBatoledo@ciandt.com
#3 rules_forms-coding_standards_2707443-3.patch50.42 KBatoledo@ciandt.com
#2 rules_forms-includes_coding_standards_files_permissions-2707443-2.patch51.83 KBerickbj

Comments

caminadaf created an issue. See original summary.

erickbj’s picture

erickbj commented
StatusFileSize
new rules_forms-includes_coding_standards_files_permissions-2707443-2.patch51.83 KB

The attached patch fixes all files permissions (from 755 to 644 where appropriate) and Drupal coding standards for files under the includes/ directory. Coding standards were checked with phpcs, using option standards as "Drupal" and "DrupalPractice".

atoledo@ciandt.com’s picture

atoledo@ciandt.com commented
Status: Active » Needs review
StatusFileSize
new rules_forms-coding_standards_2707443-3.patch50.42 KB

Attached a patch fixing the coding standards for the root files. Coding standards were checked with phpcs, using option standards as "Drupal" and "DrupalPractice".

atoledo@ciandt.com’s picture

atoledo@ciandt.com commented
StatusFileSize
new rules_forms-coding_standards_2707443-4.patch50.43 KB

Disregard patch in #3, please use this one after applying #2

caminadaf’s picture

caminadaf commented
Status: Needs review » Fixed

Hey guys, code seems really good now! Thank you SO MUCH for your effort into this!

I've commited this on 7.x-2.x, and now we can finally start doing real improvements on this version!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.