Problem/Motivation

TODO, see title

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 db_query_changed-2706201-2.patch983 bytesedumarbest

Comments

dawehner created an issue. See original summary.

edumarbest’s picture

edumarbest commented
Assigned: Unassigned » edumarbest
edumarbest’s picture

edumarbest commented
Status: Active » Needs review
StatusFileSize
new db_query_changed-2706201-2.patch983 bytes

Changed

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Looks great for me!

Btw. this helps with error logging in some edge cases like kernel tests, at which situation database.inc was not loaded. Sadly I never understood why this was the case in the first place.

edumarbest’s picture

edumarbest commented

Thanks, dawehner. I'll search another issue to contribute too. This was my first experience doing that.

dawehner’s picture

dawehner
Primary language German
commented

cool! In general yeah it can be tricky to find issues to work on. Maybe choose a specific component and try to clean up that queue, it should have a bunch of items, and you'll learn a lot about this specific component.

edumarbest’s picture

edumarbest commented

You're right! I'll take your advice! Thanks

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed be38e0c and pushed to 8.2.x. Thanks!

  • alexpott committed be38e0c on 8.2.x 
    Issue #2706201 by edumarbest: Use $this->connection->query instead of...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Turns out this fixes #2749255: PHP7 sqlite tests failing on 8.1.x so cherry-picked to 8.1.x