Needs review
Project:
Views Save
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
13 Apr 2016 at 03:35 UTC
Updated:
3 May 2016 at 10:17 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
pradeep22saini commentedComment #3
pradeep22saini commentedComment #4
drunken monkeyThanks for posting this!
Aside from a few code style issues, this does seem sensible. However, I'm not sure whether it's actually useful enough to be committed to the module, it seems rather specific and kind of a niche functionality (which you could also implement in your own custom module, as far as I can see).
I'll think about it, but will probably wait until there are other people interested in this.
Also, why do you trigger the event on the body and not the window – any specific reason? And why has the event a different name than the command, isn't that confusing?
Comment #5
pradeep22saini commentedthanks for Review @drunken monkey
I have made some changes and updated the patches with few modification with ajax refresh.
Comment #6
drunken monkeyWhy this change? That seems to be completely unrelated, and also like it would break existing functionality.