Currently, migrate_yaml just calls getKeySchema on the specified destination. Certain destinations might require additional parameters to work correctly (e.g., MigrateDestinationTable). We should add support for that, probably like:

destination:
  class: MigrateDestinationTable
  arguments:
    - table_name
  key_schema_arguments:
    - table_name

Comments

hussainweb created an issue. See original summary.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Active » Closed (works as designed)

Ah, it seems migrate already takes care of this.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Closed (works as designed) » Needs work

I am confused. This is indeed necessary.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs work » Fixed

Without passing in the arguments, MigrateDestinationTable::getKeySchema() returns an empty array. This is a problem for mapping table as there will be no destination id's.

This is now fixed in 7ec62a9.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.