Problem/Motivation

The description of the module does not follow the Help text standard, as set out in https://www.drupal.org/node/632280

Proposed resolution

Reword the description as one concise sentence.

Remaining tasks

User interface changes

This is a UI text change.

API changes

Data model changes

CommentFileSizeAuthor
#7 2702537-bigpipe-module-description-7.patch536 bytesifrik
#4 2702537-bigpipe-module-description-4.patch532 bytesifrik
#2 2702537-bigpipe-module-description-2.patch73.18 KBifrik
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ifrik created an issue. See original summary.

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented
Status: Active » Needs review
FileSize
2702537-bigpipe-module-description-2.patch73.18 KB

I've edited the module description that in the info.yml file so that it's in line with the Help text standard. I've removed the reference to the BigPipe technology here, because that's already in the name.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Title: Edit the BigPipe module description » Update the BigPipe module description to be in line with the Help text standard
Status: Needs review » Needs work

If you can reroll the patch to not include your composer.lock, then I'll RTBC :)

Thanks!

P.S.: note that I included that bit you removed simply to explain where the name comes from. But I'm happy to remove it if that's what the standard asks.

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented
Status: Needs work » Needs review
FileSize
2702537-bigpipe-module-description-4.patch532 bytes

Sorry about the composer file.

I found a different way of shortening the description and still keeping the technique in there.

pguillard’s picture

pguillard CreditAttribution: pguillard commented
Status: Needs review » Reviewed & tested by the community

Looks good

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Reviewed & tested by the community » Needs review

Shouldn't that be using the BigPipe technique? Without the the, it sounds like a broken sentence to me?

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented
FileSize
2702537-bigpipe-module-description-7.patch536 bytes

We can add the "the" :-)

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs review » Reviewed & tested by the community

Works for me! :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed ae7894f and pushed to 8.1.x and 8.2.x. Thanks!

Given that the module is being added in 8.1.0 let's fix this in the release candidate too.

  • alexpott committed d6a1d8e on 8.2.x 
    Issue #2702537 by ifrik, Wim Leers: Update the BigPipe module...

  • alexpott committed ae7894f on 8.1.x 
    Issue #2702537 by ifrik, Wim Leers: Update the BigPipe module...
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

+1

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented

Thanks a lot for that!

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

Also committed & pushed to the contrib module for Drupal 8.0: http://drupalcode.org/project/big_pipe.git/commit/45f2189

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.