While testing 8.1.0-rc1 i saw that in ckeditor the bulleted list has the icon of the numbered list, the numbered list has the maximize icon, the undo arrow has the table icon, the table has the special icon and the maximize has the paste from word icon.

This are the one i have tested so far the only thing i did was upgrade a test site from 8.0.6 to 8.1.0-rc1 and that immediately happens.

Comments

wolfhowling created an issue. See original summary.

wim leers’s picture

Title: Ckeditor Mixing-up Icons » CKEditor's Moono skin does not respect the CKEditor cache-busting query string when loading its icons sprite
Assigned: Unassigned » mlewand
Issue tags: +Needs upstream bugfix
Related issues: +#2679903: CKEditor uses separate cache-busting query string from Drupal's

This is a browser cache issue: the icons.png image sprite has changed since version 8.0, but your browser still has it cached. Clearing the browser cache, or doing a hard refresh of this page (CTRL/CMD+R) would fix it.

However … #2679903: CKEditor uses separate cache-busting query string from Drupal's should have fixed that. But I see now that the image sprite is requested without the cache-busting query string — CKEditor seems to only use that for plugins it requests. This appears to be the case because it is requested from CSS. I'm not sure if there's anything we can do about that. Assigning to @mlewand from the CKEditor team.

See http://docs.ckeditor.com/#!/api/CKEDITOR-property-timestamp — which says:

A constant string unique for each release of CKEditor. Its value is used, by default, to build the URL for all resources loaded by the editor code, guaranteeing clean cache results when upgrading.

However, clearly, that is not happening.

wim leers’s picture

Version: 8.1.0-rc1 » 8.1.x-dev
Status: Active » Postponed

Confirmed by the CKEditor team:

reinmar [11:49 AM]  Yup, that’s a sad truth – cache busting does not cover icons. We were planning to fix it, but we lost the only guy who had time and knowledge about the CKBuilder (cause that’s not CKEditor’s fault itself) :(.
wimleers [11:50 AM]  right
wimleers [11:51]  yeah the fact that it's loaded from CSS makes it hard
wimleers [11:51]  But it'd be great if the documentation for `CKEDITOR.timestamp` could be updated in the mean time, and preferably even link to a ticket
wimleers [11:51]  Better to be honest about the gotchas :)
reinmar [12:38 PM] That’s true. Especially, that it doesn’t seem that we have resources to work on this fix. I’m sad that we actually lost two guys who could do this… life.

Nothing Drupal can do here.

mlewand’s picture

wim leers’s picture

wim leers’s picture

As indicated in http://ckeditor.com/blog/CKEditor-Biweekly-for-April-26-2016, this is being fixed upstream! :) :) So, hopefully in a patch release of 8.1, and otherwise in 8.2 and other versions, this won't be a problem anymore.

wiifm’s picture

Issue summary: View changes
StatusFileSize
new28.58 KB

Just came across this upgrading from 8.0.6 -> 8.1.0 with a fairly vanilla Drupal 8 site.

issue

This is going to rain confusion over everyone. No amount of cache clearing, or force reloading seems to fix this either.

Edit - after dumping the entire browser caching of images and files (637MB worth) the issue is resolved.

wiifm’s picture

Issue summary: View changes

removing issue summary images that should not be there.

wim leers’s picture

Title: CKEditor's Moono skin does not respect the CKEditor cache-busting query string when loading its icons sprite » [upstream] CKEditor's Moono skin does not respect the CKEditor cache-busting query string when loading its icons sprite

Reflecting that this is blocked on upstream.

nicholas.alipaz’s picture

StatusFileSize
new34.74 KB

As @wiifm said,

after dumping the entire browser caching of images and files (637MB worth) the issue is resolved.

I did the same in Google Chrome:
Google Chrome cache clearing screenshot

mlewand’s picture

Assigned: mlewand » wim leers
Status: Postponed » Needs review

We've been able to push it earlier into 4.5.9 version which just has released. Please confirm if it fixes the problem for you.

thpoul’s picture

Title: [upstream] CKEditor's Moono skin does not respect the CKEditor cache-busting query string when loading its icons sprite » [PP-1] CKEditor's Moono skin does not respect the CKEditor cache-busting query string when loading its icons sprite
Issue tags: -Needs upstream bugfix
Related issues: +#2724225: Update CKEditor library to 4.5.9

Reflecting what #11 states.

wim leers’s picture

Status: Needs review » Postponed

This is now still postponed, it's blocked on #2724225: Update CKEditor library to 4.5.9, which I just RTBC'd.

wim leers’s picture

Title: [PP-1] CKEditor's Moono skin does not respect the CKEditor cache-busting query string when loading its icons sprite » [upstream] CKEditor's Moono skin does not respect the CKEditor cache-busting query string when loading its icons sprite
Status: Postponed » Closed (duplicate)

#2724225: Update CKEditor library to 4.5.9 landed, which fixed this! :)