Problem/Motivation

The description of the Drupal Upgrade UI module on the Extend page does not follow the standard, as laid out on https://www.drupal.org/node/632280

Proposed resolution

Change the description provided in migrate_drupal_ui.info.yml to something like
"Provides a user interface for direct upgrades from older Drupal versions."

Remaining tasks

Edit the descripition in migrate_drupal_ui.info.yml

User interface changes

This is a UI text change.

API changes

Data model changes

CommentFileSizeAuthor
#9 drupal-upgrade-ui-module-description-2701779-9.patch558 bytessaurabhsirdixit
#6 drupal-upgrade-ui-module-description-2701779-6.patch564 bytespguillard
#4 2701779-drupal-upgrade-ui-module-description-4.patch73.23 KBifrik

Comments

ifrik created an issue. See original summary.

ifrik’s picture

ifrik
she/her
commented
Title: Edit module description on Extend page » Edit Drupal Upgrade UI module description on Extend page
Version: 8.1.0-rc1 » 8.2.x-dev

Sorry, this should have been for 8.2

ifrik’s picture

ifrik
she/her
commented

working on this during DrupalBCDays

ifrik’s picture

ifrik
she/her
commented
Status: Active » Needs review
Issue tags: +Novice, +DrupalBCDays
StatusFileSize
new 2701779-drupal-upgrade-ui-module-description-4.patch73.23 KB

I changed the module description to start with a verb to be consistent with the Help text standard

ifrik’s picture

ifrik
she/her
commented
Status: Needs review » Needs work
pguillard’s picture

pguillard commented
Status: Needs work » Needs review
StatusFileSize
new drupal-upgrade-ui-module-description-2701779-6.patch564 bytes

I guess you should add your composer.lock to gitignore !

eojthebrave’s picture

eojthebrave
he/him
Primary language English
Location Minneapolis, MN
commented
Status: Needs review » Reviewed & tested by the community

Per the guidelines this starts with a verb and is short and concise.

Looks good to me. Thanks @pguillard.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

I think we should try to find a description that doesn't have the word 'upgrade' in it, similar to #2701541: Rename Drupal Upgrade UI to Migrate Drupal UI.

Right now reading the description by itself could suggest it's possible to use this to update from 8.0.x to 8.1.x.

saurabhsirdixit’s picture

saurabhsirdixit commented
Status: Needs work » Needs review
StatusFileSize
new drupal-upgrade-ui-module-description-2701779-9.patch558 bytes

I have removed the word "upgrade" from the description as suggested by @catch above.
New Description: Provides a user interface for migrating from older Drupal versions.

eojthebrave’s picture

eojthebrave
he/him
Primary language English
Location Minneapolis, MN
commented
Status: Needs review » Reviewed & tested by the community

Ooh. I like that update a lot. Nice idea @catch, and thanks for updating the patch @saurabhsirdixit.

Looks like it still matches the guidelines, and looks good otherwise so I'm going to set this back to RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 7bedc0c and pushed to 8.1.x and 8.2.x. Thanks!

I've cherry picked this to 8.1.x because migrate UI is a target for 8.1.0 so we should have this is as good as possible.

  • alexpott committed f5e679f on 8.2.x 
    Issue #2701779 by ifrik, pguillard, saurabhsirdixit, catch: Edit Drupal...

  • alexpott committed 7bedc0c on 8.1.x 
    Issue #2701779 by ifrik, pguillard, saurabhsirdixit, catch: Edit Drupal...
ifrik’s picture

ifrik
she/her
commented

Thanks a lot!

saurabhsirdixit’s picture

saurabhsirdixit commented

Thank you :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.