When switching from a default display to a field level display, the UUID of the display is not changed. This means that subsequent IPE edits have the same UUID as the default and will show the in-progress edits of the specific node on every change until "save as custom" is clicked again.

CommentFileSizeAuthor
#2 2701349-2.patch768 byteseclipsegc

Comments

EclipseGc created an issue. See original summary.

eclipsegc’s picture

Status: Active » Needs review
StatusFileSize
new768 bytes

CODE!

dsnopek’s picture

Thanks! Just looking at the patch, that looks good. If we can get someone to independently test this and RTBC, that'd be amazing. :-) Otherwise, I'll try to find some time to test it myself later.

dsnopek’s picture

damienmckenna’s picture

@dnsopek: :p Should this have tests too?

dsnopek’s picture

Issue tags: +Needs tests

Oh, yeah, it'd be great if this had tests!

phenaproxima’s picture

This patch has been in Lightning since forever and it hasn't broken anything for us :) That hopefully qualifies as RTBC, but tests would be good. I'm willing to write those if someone will give me some guidance.

damienmckenna’s picture

Status: Needs review » Fixed

Lets commit this and move the tests into a new issue: #2833728: Tests for generating new UUIDs for displays when switching from default to field storage

@phenaproxima: Can you please work on that one?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.