Entity reference fields that point to a user have an option ' Include the anonymous user'. If I unselect this, and set the field to use a select list for its widget, then the select list in the entity form shows the anonymous user.

CommentFileSizeAuthor
#4 interdiff.txt2.63 KBamateescu
#4 exclude_anonymous_user_selection-2700405-4.patch2.66 KBamateescu
#4 2700405-4-test-only.patch1.34 KBamateescu
#2 exclude_anonymous_user_selection-2700405-2.patch1008 bytesvasike

Comments

joachim created an issue. See original summary.

vasike’s picture

vasike
Location Ramnicu Valcea
commented
Version: 8.2.x-dev » 8.1.x-dev
Assigned: Unassigned » vasike
Status: Active » Needs review
StatusFileSize
new exclude_anonymous_user_selection-2700405-2.patch1008 bytes

indeed. there is an issue for the UserSelection's EntityReferenceSelection plugin.

This plugin works for the autocomplete widget as there is name column involved and "Anonymous" has no name.

So actually the issue here is that the buildEntityQuery does not Exclude Anonymous user, if "not included".

and here is patch for this.

p.s. moved to 8.1.x

vasike’s picture

vasike
Location Ramnicu Valcea
commented
Issue tags: +DCTransylvania
amateescu’s picture

amateescu commented
Title: User ref field includes the Anonymous user when include_anonymous is set not to, when using select widget » User ref field includes the Anonymous user when 'include_anonymous' is set not to, when using select widget
Assigned: vasike » Unassigned
Related issues: +#2434697: Remove UserAutocompleteController
StatusFileSize
new 2700405-4-test-only.patch1.34 KB
new exclude_anonymous_user_selection-2700405-4.patch2.66 KB
new interdiff.txt2.63 KB

This bug occurs because the select list widgets do not filter by the label column like the autocomplete one does, and in #2434697: Remove UserAutocompleteController we forgot to add tests for this case. Here's a small test for that.

The fix makes sense. I just made a small cosmetic change in there, so moving straight to RTBC.

amateescu’s picture

amateescu commented
Status: Needs review » Reviewed & tested by the community

Oops :)

joachim’s picture

joachim commented

Does this need tests?

amateescu’s picture

amateescu commented

It does and I added them in #4 :)

The last submitted patch, 4: 2700405-4-test-only.patch, failed testing.

amateescu’s picture

amateescu commented

And they fail/pass as expected.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.2.x and cherry-picked to 8.1.x. Thanks!

  • catch committed 23f5a1c on 8.1.x 
    Issue #2700405 by amateescu, vasike: User ref field includes the...

  • catch committed 43a7432 on 8.2.x 
    Issue #2700405 by amateescu, vasike: User ref field includes the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rosinegrean’s picture

rosinegrean commented
Issue tags: -DCTransylvania