Hi,

I have updated and added some functionality to this module. However I do not have access to cvs and so I cannot provide patch for my changes and therefore I have attached the whole module to this issue.

The changes I have done are just to fit my needs for this module so I believe you will want to first review the functionality as well as the code and then decide if you use any of those.

The changes include:
* configurable list of social network sites
* possibility to configure if the bookmarking url will open in new browser window or not
* I will be soon implementing a feature to choose icons and/or links, I might add it here then.

CommentFileSizeAuthor
#7 cs_social_networks.tgz8.59 KBblueminds
#2 cs_social_networks.tgz8.2 KBblueminds

Comments

meba’s picture

meba commented
Status: Active » Needs work

- you don't need CVS access to download code. Just download 6.x-1.x-dev version OR use this handbook page for checking out CVS code: http://drupal.org/node/321

- please don't forget the attachment :-)

blueminds’s picture

blueminds commented
StatusFileSize
new cs_social_networks.tgz8.2 KB

Then all fine as I downloaded the 6.x-1.x-dev

also here is the file... :)

meba’s picture

meba commented
Status: Needs work » Needs review

Created a patch, just to be precise...

meba’s picture

meba commented

Hmm, did not attach?

meba’s picture

meba commented

testing again...

meba’s picture

meba commented
Status: Needs review » Needs work

Seems that drupal.org is broken. Anyway, the patch looks overally good, but I can't agree with the "availablenetworks" settings form. The textarea may be too hard for users to use...

Please try to get inspired by other odules with multiple line settings such as poll module (may NOT be the best example as poll module may have issues with Forms API). My idea is having a form with 3 columns for Network name, Home Link and Bookmark link. There should be a button for adding more options (definitely used in poll module).

blueminds’s picture

blueminds commented
StatusFileSize
new cs_social_networks.tgz8.59 KB

Hi,

I have added also support for icons and setting to turn off/on the display of links while showing teasers list.

I agree that availablenetworks setting is not user friendly, I might take a look at it.

meba’s picture

meba commented
Title: added some new features » New features: icons, etc.

I propose following:

Create a patch with new features but old way to add networks. After committing, let's look at doing it new way...