When we bump versions in \Drupal::VERSION we also need to bump the version in composer json.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 2697637-8.2-9.patch | 337 bytes | xjm |
| #9 | 2697637-8.1-9.patch | 337 bytes | xjm |
| #2 | 2697637-8.2-2.patch | 693 bytes | alexpott |
| #2 | 2697637-8.1-2.patch | 693 bytes | alexpott |
Comments
Comment #2
alexpottComment #3
bojanz commentedIn the "I can't believe we forgot that part" section :)
Comment #4
xjm@alexpott So to be clear, this is only for minors, not for patch releases?
Comment #5
alexpott@xjm interesting question
Comment #6
bojanz commentedOnly for minors, since they correspond to branches. That is the point of the version requirement.
Comment #7
catchWe should drop the VERSION comment from both patches then, since that gets updated for patch releases.
Comment #8
xjmYeah, so I think the time we need to update this is when branching, not when releasing. So agreed with removing the docblock section (though it was a good suggestion).
I started to add it on https://www.drupal.org/core/maintainers/create-core-release, but then decided we should actually have a separate handbook page in the maintainer handbook about creating a new core branch for the same reason. For now, I made a stub: https://www.drupal.org/node/2699919
Comment #9
xjmI did that. Re-RTBCing since this is just a docs change. No interdiff because it's kinda obvious. :)
I'm also going to call this an RC target because I don't think we should ship 8.1.0 with this bug (though hopefully we can get it in before the RC anyway).
Comment #12
catchCommitted/pushed to 8.2.x and 8.1.x, thanks!