When we bump versions in \Drupal::VERSION we also need to bump the version in composer json.

CommentFileSizeAuthor
#9 2697637-8.2-9.patch337 bytesxjm
#9 2697637-8.1-9.patch337 bytesxjm
#2 2697637-8.2-2.patch693 bytesalexpott
#2 2697637-8.1-2.patch693 bytesalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 2697637-8.1-2.patch693 bytes
new 2697637-8.2-2.patch693 bytes
bojanz’s picture

bojanz commented
Status: Needs review » Reviewed & tested by the community

In the "I can't believe we forgot that part" section :)

xjm’s picture

xjm
she/her
Primary language English
commented

@alexpott So to be clear, this is only for minors, not for patch releases?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

@xjm interesting question

bojanz’s picture

bojanz commented

Only for minors, since they correspond to branches. That is the point of the version requirement.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

We should drop the VERSION comment from both patches then, since that gets updated for patch releases.

xjm’s picture

xjm
she/her
Primary language English
commented

Yeah, so I think the time we need to update this is when branching, not when releasing. So agreed with removing the docblock section (though it was a good suggestion).

I started to add it on https://www.drupal.org/core/maintainers/create-core-release, but then decided we should actually have a separate handbook page in the maintainer handbook about creating a new core branch for the same reason. For now, I made a stub: https://www.drupal.org/node/2699919

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs work » Reviewed & tested by the community
Issue tags: +rc target
StatusFileSize
new 2697637-8.1-9.patch337 bytes
new 2697637-8.2-9.patch337 bytes

I did that. Re-RTBCing since this is just a docs change. No interdiff because it's kinda obvious. :)

I'm also going to call this an RC target because I don't think we should ship 8.1.0 with this bug (though hopefully we can get it in before the RC anyway).

  • catch committed f294840 on 8.2.x 
    Issue #2697637 by alexpott, xjm: Update composer.json to have correct...

  • catch committed 4484605 on 8.1.x 
    Issue #2697637 by alexpott, xjm: Update composer.json to have correct...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.2.x and 8.1.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.