Unable to create more than one search page

Please provide more details about the error you are getting. What were you doing before to get that exception?

Hmm, I can't reproduce the error. Are you entering something specific in the path or so ?

Ok, I think I see the problem: you're probably entering "search-page/{keys}" as the path. But you can't add {keys}, that's going to clash with symfony, and it's not necessary either.

I was finally able to reproduce this and fix it. Patch attached, but already committed and pushed!

The patch, which is committed, is bad and makes other problems.

Now there are this if statement.

if (empty($path)) {
  $path = $default_path;
}
else {
 $path = $default_path;
}

it is equal to

$path = $default_path;

and it rewrites previously declared $path variable.

My proposed solution is to remove that if statement and just change one line
- $default_path = $search_api_page->getPath();
+ $path = $search_api_page->getPath();

I agree with @Evaldas Užkuras, patch attached removes the extra non-required code.

What's the other problem ?

As confusing as it looks, there's actually a case in multilingual sites where the config override returns null. Granted, they all use the same variable name, so it could be made more clear. Reverting would break it again, so the patch in #13 is wrong.

Closing for now. Please open an issue if there are other bugs, but other than that it confuses, nothing is actually wrong with it.

Made some testings and found. that now the paths is not generated for languages.
Then using Configuration translation and having more then 1 language it is possible to enter search page path for each language.
And now the default path is used.

It's because my early mentioned if statement always overrides $path with default value, instead of keeping one, that was returned from language config override.

Adding patch, which fixes this problem.

committed and pushed, thanks!