Panopoly Search is logging searches so that the 'Top search phrases' report is correct per #2423841: "Top search phrases" report not showing any data.

However, it's not checking if the keywords are empty or not before logging. While the search page at search/site provided by Panopoly won't let you leave the keywords empty, an other search page created by a user could allow empty keywords (and have other search fields that are required). When searching on such a page, entries like "Searched Content for ." will appear in the log.

CommentFileSizeAuthor
#2 panopoly_search-log-empty-keys-2694253-2.patch622 bytesdsnopek

Comments

dsnopek created an issue. See original summary.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Active » Needs review
StatusFileSize
new panopoly_search-log-empty-keys-2694253-2.patch622 bytes

Patch is attached!

cboyden’s picture

cboyden commented
Status: Needs review » Reviewed & tested by the community

This is working great so far as it goes. Searches are only being logged if there's a keyword field which has input, so there are no empty log messages.

There may be some other improvements that could be made, but I think this makes sense as it is.

  • dsnopek committed 66647d1 on 7.x-1.x 
    Update Panopoly Search for Issue #2694253 by dsnopek, cboyden: Don't log...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.