Problem/Motivation

FieldEntityTranslationTest::setUp calls $content_translation_manager->setEnabled('node', 'article', 'title'), but the third param should be a boolean.

Proposed resolution

Fix the calls and remove duplication, as with the first one is enough because those are default translatable values.

Remaining tasks

Create a patch.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#3 wrong_calls_to-2692827-3.patch966 bytesfoxtrotcharlie

Comments

penyaskito created an issue. See original summary.

foxtrotcharlie’s picture

foxtrotcharlie commented
Assigned: Unassigned » foxtrotcharlie
foxtrotcharlie’s picture

foxtrotcharlie commented
Status: Active » Needs review
StatusFileSize
new wrong_calls_to-2692827-3.patch966 bytes

Changed third parameter in call to ContentTranslationManagerInterface::setEnabled to TRUE, and removed the 2 following redundant calls.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

Thanks!

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

  • catch committed 5fa0558 on 8.2.x 
    Issue #2692827 by foxtrotcharlie: Wrong calls to...

  • catch committed b934da6 on 8.1.x 
    Issue #2692827 by foxtrotcharlie: Wrong calls to...
catch’s picture

catch
he/him
Primary language English
commented
Version: 8.2.x-dev » 8.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.2.x and cherry-picked to 8.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.