Problem/Motivation

Steps to reproduce:

  1. Install minimal profile
  2. Install config module
  3. Export configuration to staging directory (drush cex -y is the easiest way to do this)
  4. Change the site title
  5. Go to admin/config/development/configuration and view the config differences

Proposed resolution

Add dependency to core/drupal.ajax

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 2692359-2.patch325 bytesalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 2692359-2.patch325 bytes

So now to work out why this fixes it...

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Isn't it simply the controller for /admin/config/development/configuration that fails to attach this asset library?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Well admin/structure/block is also broken... there seems to be the assumption that 'data-dialog-type' => 'modal' only requires core/drupal.ajax

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Maybe the library all these things should be attaching is drupal.dialog.ajax?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 2692359-6.patch1.05 KB

Yep that fixes it.

nod_’s picture

nod_
Primary language French
Location Lille
commented
StatusFileSize
new config-changes.png111.63 KB

Apart from the CSS messing things up, I do see the modal open when I do exactly the steps of the OP. I really do not want drupal.ajax depending on jquery UI.

When the page is loaded things are fine, clicking on View differences will trigger an ajax request, which returns a command array, on item of this array is the inclusion of a js file, that contains jquery ui & co. and the next command is the openDialog command. Do you have any js error?

If this fails it means that the js file didn't load before the openDialog command triggered. Which is a know limitation of our ajax framework, there is an issue somewhere about it.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: core/drupal.ajax seems to have an undeclared dependency on core/jquery.ui » Use core/drupal.dialog.ajax when using data-dialog-type
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 2692359-6.patch1.05 KB

d.o xpost bug means that #7 removes the file I added in #6 :)

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community

Better, thanks!

catch’s picture

catch
he/him
Primary language English
commented
Version: 8.2.x-dev » 8.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.2.x and cherry-picked to 8.1.x, thanks!

  • catch committed 8a8fc5b on 8.2.x 
    Issue #2692359 by alexpott, nod_: Use core/drupal.dialog.ajax when using...

  • catch committed 2dc8c21 on 8.1.x 
    Issue #2692359 by alexpott, nod_: Use core/drupal.dialog.ajax when using...
drumm’s picture

drumm
he/him
Location NY, US
commented
Version: 8.2.x-dev » 8.1.x-dev
Status: Needs review » Fixed

Correcting issue status, see #2698635: Issue statuses changing by themselves?.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.