CommentFileSizeAuthor
#17 2692317-follow-up.patch1.1 KBwim leers
#14 interdiff.txt2.57 KBwim leers
#14 refreshless_head-2692317-14.patch15.33 KBwim leers
#13 interdiff.txt3.93 KBwim leers
#13 refreshless_head-2692317-13.patch14.78 KBwim leers
#12 interdiff.txt691 byteswim leers
#12 refreshless_head-2692317-12.patch13.13 KBwim leers
#10 interdiff.txt3.87 KBwim leers
#10 refreshless_head-2692317-10.patch13.05 KBwim leers
#8 interdiff.txt1.42 KBwim leers
#8 refreshless_head-2692317-8.patch11.99 KBwim leers
#7 interdiff.txt4.31 KBwim leers
#7 refreshless_head-2692317-7.patch11.71 KBwim leers
#6 interdiff.txt2.24 KBwim leers
#6 refreshless_head-2692317-6.patch10.28 KBwim leers
#5 refreshless_head-2692317-5.patch8.09 KBwim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Project: Turbolinks » RefreshLess
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#2478393: hook_page_(attachments|attachments_alter|top|bottom)() should specify the right cacheability metadata
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » wim leers
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new refreshless_head-2692317-5.patch8.09 KB

Ugly, hacky initial version, but it works. Clean-up to follow.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new refreshless_head-2692317-6.patch10.28 KB
new interdiff.txt2.24 KB

I forgot two very important hunks.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new refreshless_head-2692317-7.patch11.71 KB
new interdiff.txt4.31 KB

Cleaned up the event subscriber.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new refreshless_head-2692317-8.patch11.99 KB
new interdiff.txt1.42 KB

Cleaned up the new AJAX command.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new refreshless_head-2692317-9.patch12.75 KB
new interdiff.txt4.59 KB

First round of simplification for RefreshlessRenderer.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new refreshless_head-2692317-10.patch13.05 KB
new interdiff.txt3.87 KB

Second round of simplification for RefreshlessRenderer: the calculation of <title>. This now is also guaranteed to work with any theme's custom page title processing/rendering.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#2705293: [PP-1] A page's <title> should not be determined by html.html.twig and hook_preprocess_html(), but should be #attached and bubbled up

Opened #2705293: [PP-1] A page's <title> should not be determined by html.html.twig and hook_preprocess_html(), but should be #attached and bubbled up for 10.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new refreshless_head-2692317-12.patch13.13 KB
new interdiff.txt691 bytes

Updated patch per #11.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new refreshless_head-2692317-13.patch14.78 KB
new interdiff.txt3.93 KB

Third round of simplification for RefreshlessRenderer: the calculation of HTML <head>.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new refreshless_head-2692317-14.patch15.33 KB
new interdiff.txt2.57 KB

Cleaned up the JS.

  • Wim Leers committed 90d0ed0 on 8.x-1.x 
    Issue #2692317 by Wim Leers: Make everything in <head> update:...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Fixed
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new 2692317-follow-up.patch1.1 KB

Noticed a small bug, pushing a follow-up commit.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.