in #2409209: Replace all _url() calls beside the one in _l() the parameters of ViewExecutable::getUrl() changed to no longer include $path, there is however still a check on isset($path), which will now always be false. So lets get rid of the check and move the setting of the variable to a spot just before it gets used while we are at it.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Lendude created an issue. See original summary.

Lendude’s picture

Status: Active » Needs review
FileSize
1014 bytes

And there we go.

Lendude’s picture

Assigned: Lendude » Unassigned
dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Ha, good observation!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 8ca5abf and pushed to 8.1.x and 8.2.x. Thanks! Given the 0 impact of this change committed to 8.1.x too.

  • alexpott committed 3a9fafe on 8.2.x
    Issue #2691741 by Lendude: Remove leftover isset() in ViewExecutable
    

  • alexpott committed 8ca5abf on 8.1.x
    Issue #2691741 by Lendude: Remove leftover isset() in ViewExecutable
    
    (...
drumm’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.