in #2409209: Replace all _url() calls beside the one in _l() the parameters of ViewExecutable::getUrl() changed to no longer include $path, there is however still a check on isset($path), which will now always be false. So lets get rid of the check and move the setting of the variable to a spot just before it gets used while we are at it.

CommentFileSizeAuthor
#2 viewsexecutable_isset-2691741-2.patch1014 byteslendude

Comments

Lendude created an issue. See original summary.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Active » Needs review
StatusFileSize
new viewsexecutable_isset-2691741-2.patch1014 bytes

And there we go.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Assigned: lendude » Unassigned
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Ha, good observation!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 8ca5abf and pushed to 8.1.x and 8.2.x. Thanks! Given the 0 impact of this change committed to 8.1.x too.

  • alexpott committed 3a9fafe on 8.2.x 
    Issue #2691741 by Lendude: Remove leftover isset() in ViewExecutable

  • alexpott committed 8ca5abf on 8.1.x 
    Issue #2691741 by Lendude: Remove leftover isset() in ViewExecutable

(...
drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Fixed

Correcting issue status, see #2698635: Issue statuses changing by themselves?.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.