Hi,

After updating to 7.x-1.3 I receive the following error in Commerce shopping cart:

Notice: Undefined index: fax in addressfield_format_phone_generate() (line 69 of /foo/sites/all/modules/addressfield_phone/plugins/format/phone.inc).

By the way, I have no Fax number field set in customers profiles.

I appreciate any help to fix the issue.

Thanks.

Comments

msamavi created an issue. See original summary.

msamavi’s picture

Issue summary: View changes
agon024’s picture

Same thing with me just downloaded this to use it for the first time and I am getting Notice: Undefined index: fax in addressfield_format_phone_generate() (line 69 of /foo/sites/all/modules/addressfield_phone/plugins/format/phone.inc).

cybermache’s picture

perhaps changing it to match the other settings?
so instead of this

    if (!$settings || $settings['fax']) {

change line 69 to this

    if (!$settings || isset($settings['fax'])) {
natts’s picture

Thanks cybermache, #4 works for me.

Will this fix be rolled into the next version of this module?

brainhell’s picture

Thanks cybermache, #4 works for me very well. Another question: how can i change the phone fields order?
For example:

Mobile Phone number
Phone number
phone number extension

instead

Phone number
Phone number extension
Mobile phone number

Thanks advanced.......

cybermache’s picture

@natts, I'm not a contributor on this module so can't say when or if this will be rolled into the next release. I believe the process is first a patch needs to be submitted then that patch needs to be confirmed by the community. Since this is one line and possibly something overlooked during the last update, it happens to me on occasion, it might just get added the next time around. I'm not going to hold my breath though.

@brainhell I would suggest opening a request issue for your question. From my experience it's best to keep these issues focused on the initial topic. Otherwise an issue could potentially never be resolved. Plus, it helps keep things clear for those trying to fix the original issue. I would also suggest clarifying where you are looking to change this order, when the field values are being displayed or entered.

balintcsaba’s picture

Category: Bug report » Task
Status: Active » Needs review
StatusFileSize
new577 bytes
neograph734’s picture

Version: 7.x-1.3 » 7.x-1.x-dev
Status: Needs review » Reviewed & tested by the community

Works great. Let's get this in the next dev.

vasike’s picture

Category: Task » Bug report

i confirm both : the issue and the patch solution from #8

and i think this is a bug.

coreykck’s picture

Bug solved by #8
Tnx

madelyncruz’s picture

Patch #8 works. Thank you.

c_lehel’s picture

Patch #8 works fine. Thank you.

ollie222’s picture

Another thumbs up for patch #8.

Can we get this committed please?

jcisio’s picture

Thanks. Committed and pushed.

jcisio’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

br0ken’s picture

Someone, please, create a release with this fix! Tests for other module, which depends on this, are failing. :(

stijnbousard’s picture

Number #4 works for me. Thanks!