Closed (fixed)
Project:
Drupal core
Version:
8.2.x-dev
Component:
language system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 Mar 2016 at 23:12 UTC
Updated:
22 Nov 2016 at 13:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
morenstratComment #4
Ante890 commentedThank you for the patch . Should be implemented in core.
Comment #5
morenstratUpdated Patch for 8.1.x-dev
Comment #6
Ante890 commentedComment #8
Ante890 commentedComment #9
alexpottLet's test this.
Let's not do conversion to short syntax in this issue.
Comment #11
Ante890 commentedNew patch
Comment #12
Ante890 commentedComment #13
Ante890 commentedComment #14
alexpottStill needs an automated test.
Comment #15
Ante890 commentedI added a query string to doTestLanguageBlockAnonymous test function. Any feedback is welcome.
Comment #16
Ante890 commentedComment #17
Ante890 commentedComment #18
amit.drupal commentedReview patch #15 its looking good.it is nicely working
Comment #19
alexpottI think we can just do
$query = $request->query->all();instead of this.Need a space between , and $options - but I would just do this like this:
$this->drupalGet('', ['query' => ['foo' => 'bar']]);Also I would detail what the testing purpose is - ie. to ensure that the active class is added correctly if query params are present.
Comment #20
morenstratTest-only patch. This should fail.
Comment #21
morenstratComment #23
morenstratAn the complete patch with fix and test.
Comment #24
Ante890 commentedGreat work morenstrat. Now I think we have a patch that should be approved.
Comment #25
Ante890 commentedComment #28
catchCommitted/pushed to 8.3.x and cherry-picked to 8.2.x. Thanks!