Problem/Motivation

Drupal 8.1.x has removed the /vendor directory from the core repo: #1475510: Remove external dependencies from the core repo and let Composer manage the dependencies instead

This means that our normal testing procedure fails because we can't run tests. They fail because they're unable to find vendor/autoload.php.

This means we have to somehow trigger composer to install the dependencies during test runs.

This can be accomplished by setting DCI_ComposerInstall=true #2315537-56: Install composer dependencies before running tests

However, this triggers an composerinstall preprocess step which can't find the composer binary under vagrant.

Proposed resolution

In IRC Mixologic and Mile23 came up with changing DrupalCI\Plugin\BuildSteps\setup\Composer:: buildComposerCommand() to return "./bin/composer $data $workingdir"

This forces the use of whatever Composer binary was added to the testrunner project during its installation, for either the vagrant box or the production server.

Remaining tasks

User interface changes

API changes

Data model changes

Comments

Mile23 created an issue. See original summary.

mile23’s picture

Added branch 2687303-dci-composerinstall-fails-under-vagrant

Needs a follow-up to test the behavior of DCI_ComposerInstall=true and DCI_ComposerInstall=false

mile23’s picture

Status: Active » Needs review
jthorson’s picture

Status: Needs review » Reviewed & tested by the community

Duplicated, and validated ... or rather, Validated, then duplicated. Rather academic exercise, since the patch has already been committed.

Updating issue status accordingly; but will leave open as it doesn't appear that the required followup issue exists yet.

  • Mixologic committed a86b8cc on
    Issue #2687303: updates testing.md with composer install instructions
    

  • Mile23 committed bd130bc on
    Issue #2687303: Changed composer binary location to be more specific,...

  • Mixologic committed 16748bb on
    Issue #2687303: Moves composer install of drupal fixture to vagrant...
  • Mixologic committed a86b8cc on
    Issue #2687303: updates testing.md with composer install instructions
    
  • Mile23 committed bd130bc on
    Issue #2687303: Changed composer binary location to be more specific,...
Mixologic’s picture

Status: Reviewed & tested by the community » Fixed
Mixologic’s picture

mile23’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.