The boilerplate styles for the CSS (including the noscript version) should not have linebreaks in order to validate as AMP HTML.

CommentFileSizeAuthor
#9 2686807-9-boilerplate-styles.patch5.33 KBrainbowarray
#5 2686807-5-boilerplate-styles.patch3.13 KBrainbowarray
amptheme-validator-dont-allow-linebreak-in-boilerplate-styles.patch1.85 KBjansete

Comments

jansete created an issue. See original summary.

rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented

I'm not finding a validation error for this. Could you please provide more information on where you are seeing this validation error?

Zsuffa Dávid’s picture

Zsuffa Dávid commented

I can confirm the issue and removing whitespaces resolve it.

Non minified:
http://postimg.org/image/5t16ocy2n/

Minified:
http://postimg.org/image/uagp1338z/

https://www.drupal.org/node/2693233#comment-11052295

rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
Title: Validator don't allow linebreak in boilerplate styles tags » Validator doesn't allow linebreak in boilerplate styles tags
Issue summary: View changes
rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
Title: Validator doesn't allow linebreak in boilerplate styles tags » Prevent linebreaks in boilerplate styles tags to avoid validator errors
Version: 7.x-1.x-dev » 8.x-1.x-dev
StatusFileSize
new 2686807-5-boilerplate-styles.patch3.13 KB

Took a bit more work to squeeze all the space out of the boilerplate styles. Starting with patching 8.x branch, then will move to 7.x branch.

  • mdrummond committed 6e68959 on 8.x-1.x 
    Issue #2686807 by mdrummond, jansete, purencool, zsuffad: Prevent...
rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented

Merging in the 8.x fix. Working on 7.x next. Thanks for help with patches and tests everybody.

rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
Version: 8.x-1.x-dev » 7.x-1.x-dev
rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
StatusFileSize
new 2686807-9-boilerplate-styles.patch5.33 KB

Slightly different approach necessary for the D7 patch. Controlling whitespace was more of a pain without Twig, so I ended up putting all the boilerplate styles + markup into one include file.

  • mdrummond committed 731262b on 7.x-1.x 
    Issue #2686807 by mdrummond, jansete, purencool, zsuffad: Prevent...
rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.