#2638182: fix badly named variable in FeedForm Was an example of an issue where the tests would fail because the patch name itself was matching one of the paths that apache was trying to hit.

After drupalci patches a codebase, it should probably move that patch to somewhere outside of the codebase directory, or alternately download that patch to a different directory to begin with and apply from there.

Comments

Mixologic created an issue. See original summary.

jthorson’s picture

jthorson commented

This is sort of supported today, and is one of the motivations for separating DCI_Fetch from DCI_Patch.

DCI_Fetch can be passed both the source URI and a destination target directory (i.e. patches/mypatch.patch), and DCI_Patch can be passed the full local path of the source patch (patches/mypatch.patch), and a directory from which to apply it (i.e. ".").

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Component: Code » Codebase Build
Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Status: Active » Fixed

Fixed as part of composer build support. Patches are fetched to an ancillary workspace and applied from there.

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.